Shorts are a great deal for the price compared to name brands. They seem to fit true to size. My little giant wears about a 9. I got the 8 thinking the elastic would save him, but nope. Good thing I also got some 10s. The 10s fit a little loose, but I'm not worried; at 5 years old you'd be surprised at how much they grow over the school year.
Overall, very pleased with the purchase.